FINAL eamxx downstream merge! #6761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rface_back_to_kokkos * origin/master: (75 commits) add EAMxx initial condition for ne4 with L128 change from scream-docs to eamxx-scripts EAMxx: flush output file whenever we write a rhist file EAMxx: add support for daily storage type in IO EAMxx: always update num snaps in file, even for Yearly/Monthly storage clarify P3Runtime struct defaults This commit removes a docker folder in eamxx no longer in use. restore BFB in order to merge PR Remind devs to load scream env Add some Kokkos dev doc EAMxx: work on atm process developer documentation EAMxx: removed undefined method in AbstractGrid Update EAMxx docs and improve help formatters Rename set_params -> setup_internals Improve OutputManager function descriptions Separate restart output manager from output manager list Only call set_logger() once Fix run_t0 and case_t0 checks fix incorrect inputs Move set_provenence_data call to in front of create_output_managers ...
… when using a remap file.
This commit follows the example for the geometry data for 'lev' and adds 'ilev'. The variable 'ilev' will now be a default variable in all EAMxx output similar to what is currently done with lat/lon, hyam/hybm, hyai/hybi and lev. Addresses #3022
jgfouca
requested review from
bartgol,
AaronDonahue,
mahf708,
PeterCaldwell,
brhillman,
oksanaguba and
tcclevenger
|
tcclevenger
approved these changes
Nov 21, 2024
mahf708
reviewed
Nov 21, 2024
|
Congratulations, you all! |
|
I'm going to merge to next so we get testing tonight. We can simultaneously work on fixing the CI issue. |
bartgol
reviewed
Nov 21, 2024
bartgol
added
the
CI: workflow change approved
* Remove pre_process_pr jobs, in favor of paths filters * Remove support for skip labels * Simplified setting of env vars (e.g., submit/generate)
bartgol
force-pushed
the
jgfouca/final_scream_downstream_2024_11_21
branch
from
1f36ecf
to
0d3b7da
Compare
rljacob
added a commit
that referenced
this pull request
Nov 22, 2024
#6761) The scream/eamxx fork has been archived (frozen). All new scream/eamxx development will happen in the E3SM repo. [BFB]
|
merged to next. |
|
Working on a fix for the pam fail. Will push in a moment. in febfb90, the pam stuff is updated to conform to eamxx p3. The pam submodule is now pointing to this PR E3SM-Project/PAM#159 (when merged, it will be still be the correct commit, so no further update is needed; I will ask @whannah1 to review/merge the pam pr) |
bartgol
approved these changes
Nov 22, 2024
bartgol
added
CI: workflow change approved
This was referenced Nov 22, 2024
rljacob
added a commit
that referenced
this pull request
Nov 22, 2024
#6761) Second merge. Fix PAM build fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scream/eamxx fork has been archived (frozen). All new scream/eamxx development will happen in the E3SM repo.
[BFB]